Skip to content

Comments

refactor(semantic): store comments as a slice instead of &Vec#13336

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_
Aug 27, 2025
Merged

refactor(semantic): store comments as a slice instead of &Vec#13336
graphite-app[bot] merged 1 commit intomainfrom
08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 27, 2025 •
edited
Loading

Semantic storing comments as a &Vec<Comment> involves unnecessary indirection (pointer to a pointer). Store as &[Comment] slice instead.

@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 27, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Aug 27, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Aug 27, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review August 27, 2025 18:28
@overlookmotel overlookmotel requested a review from Dunqing as a code owner August 27, 2025 18:28
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13336 will not alter performance

Comparing 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ (d787517) with main (3c34767)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (d787517) during the generation of this report, so 3c34767 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel force-pushed the 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ branch from fe07544 to cb2a00e Compare August 27, 2025 20:48
@overlookmotel overlookmotel mentioned this pull request Aug 27, 2025
Merged
@graphite-app graphite-app bot changed the base branch from 08-27-refactor_benchmarks_linter_benchmark_re-run_parsing_and_semantic_on_each_iteration to graphite-base/13336 August 27, 2025 21:42
@graphite-app graphite-app bot force-pushed the 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ branch from cb2a00e to 420921a Compare August 27, 2025 21:48
@graphite-app graphite-app bot force-pushed the graphite-base/13336 branch from 5574085 to 7fdd478 Compare August 27, 2025 21:48
@graphite-app graphite-app bot changed the base branch from graphite-base/13336 to main August 27, 2025 21:48
@graphite-app graphite-app bot force-pushed the 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ branch from 420921a to cfcbe76 Compare August 27, 2025 21:48
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Aug 27, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
refactor(semantic): store comments as a slice instead of &Vec (#13336)
d787517 
`Semantic` storing comments as a `&Vec<Comment>` involves unnecessary indirection (pointer to a pointer). Store as `&[Comment]` slice instead.
@graphite-app graphite-app bot force-pushed the 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ branch from cfcbe76 to d787517 Compare August 27, 2025 22:28
@graphite-app graphite-app bot merged commit d787517 into main Aug 27, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ branch August 27, 2025 22:33
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
@overlookmotel overlookmotel mentioned this pull request Aug 27, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Aug 28, 2025
@overlookmotel
feat(semantic): derive Default for Semantic (#13343)
9a828de 
After #13336, we can derive `Default` on `Semantic`.

This is not so useful in most cases, but does allow using `std::mem::take` on a `&mut Semantic`, which is used in next PR in this stack.
@oxc-bot oxc-bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314